Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add assimilation of GLM flash-extent density (FED) observations to EnKF #654

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Add assimilation of GLM flash-extent density (FED) observations to EnKF #654

merged 2 commits into from
Dec 7, 2023

Conversation

daviddowellNOAA
Copy link
Collaborator

@daviddowellNOAA daviddowellNOAA commented Nov 8, 2023 •
edited by RussTreadon-NOAA
Loading

Description

Fixes #653

The proposed code changes
(1) add a new "fed" observation type to the EnKF
(2) add localization parameters, with namelist control, for FED observations
(3) output basic statistics for FED observations.

In the RRFS, the FED observations will be assimilated together with radar-reflectivity observations. The localization parameters for the reflectivity observations in RRFS are corrlength=18 and lnsigcutoff=0.5. However, these tight localization distances don't work well for the sparse FED observations. Therefore, localization parameters for FED observations, with namelist control, were added to allow the FED observations to influence the model state over longer distances. The default localization parameters for FED observations (corrlength=30 and lnsigcutoff=2.0) were determined through experimentation with WRF and FV3 convection-allowing (3-km horizontal grid spacing) ensembles.

Screen Shot 2023-11-08 at 8 53 09 AM Screen Shot 2023-11-08 at 8 53 02 AM

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Hourly cycling with simultaneous EnKF assimilation of FED and radar-reflectivity observations has been tested for a CONUS version of the prototype RRFSv1 for two short (1-2 days) retrospective periods, one in July 2022 and the other in August 2023. The impacts of the FED observations on the analyses are greatest over the oceans far from land, where the radar network does not provide observations.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

DUE DATE for this PR is 12/20/2023. If this PR is not merged into develop by this date, the PR will be closed and returned to the developer.

@hu5970 hu5970 self-assigned this Nov 8, 2023
@hu5970 hu5970 requested a review from TingLei-NOAA November 8, 2023 16:23
@hongli-wang
Copy link
Collaborator

@hu5970
Hi.

@TingLei-NOAA
Copy link
Contributor

@daviddowellNOAA is the current change only dealing with binary diag files? if so, what is the plan for netcdf diag files?

@hu5970 hu5970 self-requested a review November 8, 2023 17:53
@hu5970 hu5970 removed their assignment Nov 8, 2023
@hu5970
Copy link
Collaborator

hu5970 commented Nov 8, 2023

@hongli-wang
Hongli, we are not able to add you as reviewer somehow but please review and code and make your comments. Thanks, Ming.

@hongli-wang
Copy link
Collaborator

@hongli-wang Hongli, we are not able to add you as reviewer somehow but please review and code and make your comments. Thanks, Ming.

@hu5970 @daviddowellNOAA

The code is pretty clean and fellow the same procedures for other types of observations. I don't think there should be issues there as David has tested the run.

Just curious if a brief description on the new parameters could be added somewhere in the code.

Thanks,
Hongli

@hu5970 hu5970 requested a review from xyzemc November 20, 2023 17:21
@RussTreadon-NOAA
Copy link
Contributor

@hongli-wang
We invited you to join NOAA-EMC/GSI as an outside collaborator. Please check your email for an invitation. If you accept the invitation, we should be able to add you as a reviewer on GSI PRs.

@hongli-wang
Copy link
Collaborator

@hongli-wang We invited you to join NOAA-EMC/GSI as an outside collaborator. Please check your email for an invitation. If you accept the invitation, we should be able to add you as a reviewer on GSI PRs.

@RussTreadon-NOAA
Thanks for your invitation. Accepted!

@RussTreadon-NOAA
Copy link
Contributor

@hongli-wang , thank you for accepting the invitation. Now we can formally add you as a reviewer on this PR. Thanks!

@hu5970
Copy link
Collaborator

hu5970 commented Nov 29, 2023

@daviddowellNOAA Could you answer Ting's question? Thanks, Ming

@daviddowellNOAA
Copy link
Collaborator Author

@TingLei-NOAA The tests of the EnKF assimilation of FED data into a prototype RRFS used netcdf diag files. I think the new functionality should also work for binary diag files, but I can't confirm with tests.

@daviddowellNOAA
Copy link
Collaborator Author

@hongli-wang The documentation within the code is very limited, and I only included a mention of "fed obs" in enkf.f90. There is good documentation for the EnKF code in the "EnKF User's Guide". @hu5970 Do you know if there will be any more updates to the EnKF User's Guide? If so, then I would be happy to provide documentation of the new parameters for FED.

@TingLei-NOAA
Copy link
Contributor

@TingLei-NOAA The tests of the EnKF assimilation of FED data into a prototype RRFS used netcdf diag files. I think the new functionality should also work for binary diag files, but I can't confirm with tests.

@daviddowellNOAA Thanks for this clarification.

@hu5970
Copy link
Collaborator

hu5970 commented Dec 6, 2023

The regression tests on Dogwood passed:

[ming.hu@dlogin07 build] ctest -j7
Test project /lfs/h2/emc/ptmp/Ming.Hu/gsi/GSI/build
    Start 1: global_4denvar
    Start 2: rtma
    Start 3: rrfs_3denvar_glbens
    Start 4: netcdf_fv3_regional
    Start 5: hafs_4denvar_glbens
    Start 6: hafs_3denvar_hybens
    Start 7: global_enkf
1/7 Test #4: netcdf_fv3_regional ..............   Passed  482.93 sec
2/7 Test #3: rrfs_3denvar_glbens ..............   Passed  485.25 sec
3/7 Test #7: global_enkf ......................   Passed  609.82 sec
4/7 Test #2: rtma .............................   Passed  968.70 sec
5/7 Test #5: hafs_4denvar_glbens ..............   Passed  1213.92 sec
6/7 Test #6: hafs_3denvar_hybens ..............   Passed  1214.60 sec
7/7 Test #1: global_4denvar ...................   Passed  1322.47 sec

100% tests passed, 0 tests failed out of 7

Total Test time (real) = 1322.48 sec

@hu5970
Copy link
Collaborator

hu5970 commented Dec 6, 2023

The regression tests on Hera passed:

[Ming.Hu@hfe11 build]$ ctest -j7
Test project /scratch1/BMC/wrfruc/mhu/code/gsi/GSI/build
    Start 1: global_4denvar
    Start 2: rtma
    Start 3: rrfs_3denvar_glbens
    Start 4: netcdf_fv3_regional
    Start 5: hafs_4denvar_glbens
    Start 6: hafs_3denvar_hybens
    Start 7: global_enkf
1/7 Test #4: netcdf_fv3_regional ..............   Passed  545.01 sec
2/7 Test #3: rrfs_3denvar_glbens ..............   Passed  549.37 sec
3/7 Test #7: global_enkf ......................   Passed  1015.83 sec
4/7 Test #2: rtma .............................   Passed  1032.56 sec
5/7 Test #6: hafs_3denvar_hybens ..............   Passed  1158.88 sec
6/7 Test #5: hafs_4denvar_glbens ..............   Passed  1399.15 sec
7/7 Test #1: global_4denvar ...................   Passed  1606.77 sec

100% tests passed, 0 tests failed out of 7

Total Test time (real) = 1606.77 sec

@hu5970
Copy link
Collaborator

hu5970 commented Dec 6, 2023

The regression tests on Orion:

    Start 1: [=[global_4denvar]=]
    Start 2: [=[rtma]=]
    Start 3: [=[rrfs_3denvar_glbens]=]
    Start 4: [=[netcdf_fv3_regional]=]
    Start 5: [=[hafs_4denvar_glbens]=]
    Start 6: [=[hafs_3denvar_hybens]=]
    Start 7: [=[global_enkf]=]
1/7 Test #4: [=[netcdf_fv3_regional]=] ........   Passed  483.86 sec
2/7 Test #7: [=[global_enkf]=] ................   Passed  489.57 sec
3/7 Test #3: [=[rrfs_3denvar_glbens]=] ........   Passed  666.79 sec
4/7 Test #2: [=[rtma]=] .......................***Failed  1029.76 sec
5/7 Test #6: [=[hafs_3denvar_hybens]=] ........   Passed  1457.90 sec
6/7 Test #1: [=[global_4denvar]=] .............   Passed  1681.83 sec
7/7 Test #5: [=[hafs_4denvar_glbens]=] ........   Passed  1696.17 sec

86% tests passed, 1 tests failed out of 7

Total Test time (real) = 1696.18 sec

The following tests FAILED:
	  2 - [=[rtma]=] (Failed)
Errors while running CTest

The reason for rtma failure is:

The runtime for rtma_hiproc_updat is 227.950292 seconds.  This has exceeded maximum allowable threshold time of 226.470057 seconds,
resulting in Failure of timethresh2 the regression test.

So, the regression tests on Orion passed too.

@hu5970 hu5970 merged commit 2353eaa into NOAA-EMC:develop Dec 7, 2023
4 checks passed
@RussTreadon-NOAA RussTreadon-NOAA mentioned this pull request Dec 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TingLei-NOAA TingLei-NOAA TingLei-NOAA approved these changes

@hongli-wang hongli-wang hongli-wang approved these changes

@hu5970 hu5970 hu5970 approved these changes

@xyzemc xyzemc Awaiting requested review from xyzemc

Assignees

@daviddowellNOAA daviddowellNOAA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add capability of assimilating GLM flash extent density (FED) observations with EnKF
5 participants
@daviddowellNOAA @hongli-wang @TingLei-NOAA @hu5970 @RussTreadon-NOAA